Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds option to enforce no cover for sanity image #1001

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mikaelbr
Copy link
Member

@mikaelbr mikaelbr commented Dec 11, 2024

This is not the best solution as it requires the block them self to programatically set if it should be cover or not and is not left to the user of the CMS. But thinking for release/launch this is better then nothing. For this to be user controlled we'd have to replace a lot of basic settings for images around everywhere images is used or find a way to do this within sanity. Needs more research.

(Kind of) Fixes #990

But this allows for block like this at least:
Screenshot 2024-12-11 at 21 15 57
Screenshot 2024-12-11 at 21 15 46
Screenshot 2024-12-11 at 21 15 41
Screenshot 2024-12-11 at 21 15 34

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 8:24pm
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 8:24pm

@mikaelbr mikaelbr merged commit 451422d into v3 Dec 12, 2024
6 checks passed
@mikaelbr mikaelbr deleted the mikael/fix-image-non-cover branch December 12, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support non-cover image from Sanity
2 participants